Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use cases for file tab data visualization #80

Merged
merged 27 commits into from
Aug 25, 2023
Merged

Add use cases for file tab data visualization #80

merged 27 commits into from
Aug 25, 2023

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Jul 20, 2023 •
edited
Loading

What this PR does / why we need it:

Adds the use case logic to support the frontend files tab display data.

The new use case logic needs the API changes implemented in IQSS/dataverse#9692 to work.

In particular, this PR adds the following new use cases to the package:

  • getDatasetFiles
  • getFileDownloadCount
  • getFileDataTables
  • getUserPermissionsOnFile

In addition, the dataset use cases have been refactored. In particular, the old getDatasetById and getDatasetByPersistentId use cases are merged into a single getDataset use case, which is inferring the type of id specified.

Which issue(s) this PR closes:

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

New use cases for files:

  • getDatasetFiles
  • getFileDownloadCount
  • getFileDataTables
  • getUserPermissionsOnFile

GPortas added 13 commits July 10, 2023 14:44
@GPortas
Stash: getDatasetFiles use case WIP
4cee748
@GPortas
Merge branch '71-pending-integration-tests' into 77-files-display-dat…
3d915e7 
…a-use-cases
@GPortas
Added: getFilesByDatasetId use case (pending repository impl)
c9c6fbe
@GPortas
Stash: FilesRepository getFilesByDatasetId impl WIP
cd2039c
@GPortas
Added: file model attributes
a835cc3
@GPortas
Stash: files response transforming WIP
d1f2445
@GPortas
Added: files response transforming
0ef3b90
@GPortas
Added: getFilesByDatasetPersistentId use case
7f6d55a
@GPortas
Changed: restricted field payload transform
7cbf2f4
@GPortas
Stash: files repository integration test WIP (now failing)
9b305ea
@GPortas
Merge branch 'develop' of github.com:IQSS/dataverse-client-javascript…
ee2b741 
… into 77-files-display-data-use-cases
@GPortas
Fixed: file upload via API test helper
f4a6bdd
@GPortas
Added: integration tests for FilesRepository
0111e66
@GPortas GPortas self-assigned this Jul 20, 2023
@GPortas GPortas marked this pull request as ready for review July 24, 2023 10:33
@GPortas GPortas removed their assignment Jul 24, 2023
@pdurbin pdurbin changed the title 77 - Add use cases for file tab data visualization Add use cases for file tab data visualization Jul 24, 2023
@GPortas GPortas added the Size: 10 A percentage of a sprint. 7 hours. label Aug 2, 2023
@GPortas GPortas self-assigned this Aug 2, 2023
@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. Size: 10 A percentage of a sprint. 7 hours. and removed Size: 10 A percentage of a sprint. 7 hours. Size: 3 A percentage of a sprint. 2.1 hours. labels Aug 2, 2023
@GPortas GPortas removed their assignment Aug 9, 2023
@MellyGray MellyGray mentioned this pull request Aug 16, 2023
Closed
1 task
@MellyGray MellyGray self-assigned this Aug 17, 2023
@GPortas GPortas mentioned this pull request Aug 17, 2023
Merged
MellyGray
MellyGray reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passing
✅ Code looks good overall (Just a few comments, not critical things so I don't want to block this PR)

src/core/infra/repositories/ApiRepository.ts Show resolved Hide resolved
src/files/infra/repositories/FilesRepository.ts Show resolved Hide resolved
src/files/infra/repositories/FilesRepository.ts Show resolved Hide resolved
test/integration/datasets/DatasetsRepository.test.ts Show resolved Hide resolved
test/integration/datasets/DatasetsRepository.test.ts Show resolved Hide resolved
test/integration/files/FilesRepository.test.ts Show resolved Hide resolved
test/unit/files/FilesRepository.test.ts Show resolved Hide resolved
jest.config.js Show resolved Hide resolved
@GPortas GPortas removed their assignment Aug 18, 2023
@GPortas GPortas requested a review from MellyGray August 18, 2023 08:39
@MellyGray MellyGray assigned GPortas and unassigned GPortas Aug 18, 2023
MellyGray
MellyGray approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All threads solved! There is some refactoring going on in another PR to not block this one. Moving this to QA!

@MellyGray MellyGray removed their assignment Aug 18, 2023
@kcondon kcondon self-assigned this Aug 25, 2023
@kcondon kcondon merged commit 01f9e16 into develop Aug 25, 2023
@kcondon kcondon deleted the 77-files-display-data-use-cases branch August 25, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MellyGray MellyGray MellyGray approved these changes

Assignees

@kcondon kcondon

Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spike] [1/2] Add use case logic to get display file data for the frontend files tab
3 participants
@GPortas @MellyGray @kcondon